Re: [PATCH v3] pinctrl: stm32: Add check for clk_enable()

[Mingwei Zheng <zmw12306@xxxxxxxxx>]

Hi Marek,

On Sat, Dec 7, 2024 at 7:59 AM Marek Vasut <marex@xxxxxxx> wrote:
>
> On 12/6/24 10:43 PM, Mingwei Zheng wrote:
>
> [...]
>
> > @@ -1646,8 +1645,8 @@ int stm32_pctl_probe(struct platform_device *pdev)
> >               if (ret) {
> >                       fwnode_handle_put(child);
> >
> > -                     for (i = 0; i < pctl->nbanks; i++)
> > -                             clk_disable_unprepare(pctl->banks[i].clk);
> > +                     clk_bulk_disable(pctl->nbanks, pctl->clks);
> > +                     clk_bulk_unprepare(pctl->nbanks, pctl->clks);
>
> Use clk_bulk_disable_unprepare()
>
> include/linux/clk.h:static inline void clk_bulk_disable_unprepare(int
> num_clks,

Thanks! We used clk_bulk_disable_unprepare() in the patch v4.

Best,
Mingwei

>
> It looks pretty good otherwise, thanks !