Re: [PATCH 1/2] gpio: omap: allow building the module with COMPILE_TEST=y

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/3/24 10:41 AM, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>

For better build coverage, allow building the gpio-omap driver with
COMPILE_TEST Kconfig option enabled.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
---
  drivers/gpio/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 56fee58e281e7..fb923ccd79028 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -530,7 +530,7 @@ config GPIO_OCTEON
  config GPIO_OMAP
  	tristate "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
  	default y if ARCH_OMAP
-	depends on ARM
+	depends on ARM || COMPILE_TEST

Why do we have this depends on ARM at all? It already has that condition
above on ARCH_OMAP2PLUS which limits to ARM outside of compile testing.

And anything that selects ARCH_OMAP2PLUS also selects ARCH_OMAP, so we
could just do this:

--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -528,9 +528,9 @@ config GPIO_OCTEON
          family of SOCs.
config GPIO_OMAP
-       tristate "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
-       default y if ARCH_OMAP
-       depends on ARM
+       tristate "TI OMAP GPIO support"
+       default y
+       depends on ARCH_OMAP2PLUS || COMPILE_TEST
        select GENERIC_IRQ_CHIP
        select GPIOLIB_IRQCHIP
        help

Andrew

  	select GENERIC_IRQ_CHIP
  	select GPIOLIB_IRQCHIP
  	help




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux