Re: [PATCH 7/7] arm64: dts: broadcom: Fix device tree errors on BCM2712.

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 02/12/2024 15:32, Dave Stevenson wrote:
> Resolves the issues on clocks and power nodes

Which issues? Be specific. Such commit is unprecise and not really
helpful. We see it from the diff that this is "some issue". What we do
not see is WHY and WHAT the ISSUE is.

> 
> Fixes: 4254a647b6c9 ("arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT")
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>


Nothing in the DTS patches suggested targeting DRM, so this patchset is
organized in pretty surprising way. Please split them per subsystem. DTS
is never for driver subsystem.

Subject: drop full stop.

> ---
>  arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> index fbc56309660f..26e05601416f 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> @@ -66,11 +66,7 @@ &sdio1 {
>  &soc {
>  	firmware: firmware {
>  		compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> -
>  		mboxes = <&mailbox>;
> -		dma-ranges;
>  
>  		firmware_clocks: clocks {
>  			compatible = "raspberrypi,firmware-clocks";
> @@ -85,6 +81,11 @@ reset: reset {
>  
>  	power: power {
>  		compatible = "raspberrypi,bcm2835-power";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +		dma-ranges;


No address space here, so why ranges?

> +
>  		firmware = <&firmware>;
>  		#power-domain-cells = <1>;
>  	};
> 


Best regards,
Krzysztof