On 11/26/24 13:24, Linus Walleij wrote:
On Tue, Nov 26, 2024 at 5:17 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
On Mon, May 06, 2024 at 12:23:53PM +0200, Esben Haabendal wrote:
Making pinctrl drivers and subsequently the pinctrl framework
user-controllable, allows building a kernel without this.
While in many (most) cases, this could make the system unbootable, it
does allow building smaller kernels for those situations where picntrl
is not needed.
One such situation is when building a kernel for NXP LS1021A systems,
which does not have run-time controllable pinctrl, so pinctrl framework
and drivers are 100% dead-weight.
Signed-off-by: Esben Haabendal <esben@xxxxxxxxxx>
This patch didn't update default configurations, meaning PINCTRL is now
disabled by affected configurations such as imx_v4_v5_defconfig or
imx_v6_v7_defconfig, making pretty much all imx platforms non-bootable
unless the default configuration is changed manually.
Since the patch tries to add default selects for all drivers I suspect this
oneliner is the culprit:
@@ -6,7 +6,6 @@ menuconfig ARCH_MXC
select CLKSRC_IMX_GPT
select GENERIC_IRQ_CHIP
select GPIOLIB
- select PINCTRL
select PM_OPP if PM
select SOC_BUS
select SRAM
Should we just add that one line back?
My understanding (which may be wrong) is that being able to disable
PINCTRL was the whole point of the patch.
Fabio submitted a patch enabling PINCTRL for imx_v4_v5_defconfig and
imx_v6_v7_defconfig explicitly [1]. I don't know if that fixes the
problem for good - I see CONFIG_ARCH_MXC in other configurations as
well.
Guenter
---
[1] https://lore.kernel.org/imx/d718ddd2-d473-4455-b21a-15024e46787c@xxxxxxxxxxxx/T/#mc71dc21d99e0b013c5ce46c0d90940fd8806ae9a
