Re: [PATCH 121/182] pinctrl: exynos5440: use gpiochip data pointer

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Dec 11, 2015 at 7:21 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote:

>> -#include <linux/gpio.h>
>> +#include <linux/gpio/driver.h>
>
> Commit message doesn't mention this change. Do I assume correctly that
> it's needed for gpiochip_get_data() and also gives the driver access
> to all definitions it needed from linux/gpio.h?

No GPIO driver should ever use anything outside <linux/gpio/driver.h>
and it appears this one doesn't. So it's just me sneaking in some
cleanups.

> Other than that (and the fact that, as opposed to the other Exynos
> patch, this one is actually cleaner):
> Acked-by: Tomasz Figa <tomasz.figa@xxxxxxxxx>

Thanks, well the thing is that from a helicopter view, everything looks
better after this patch series, so that is why I'm pushing it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html