RE: [libgpiod][PATCH] bindings: python: tests: replace LooseVersion with packaging.version.Version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Bartosz Golaszewski <brgl@xxxxxxxx>
> Sent: Tuesday, November 19, 2024 9:20 AM
> To: Vincent Fazio <vfazio@xxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>; Kent Gibson
> <warthog618@xxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx; Bartosz Golaszewski
> <bartosz.golaszewski@xxxxxxxxxx>
> Subject: [External] - Re: [libgpiod][PATCH] bindings: python: tests: replace
> LooseVersion with packaging.version.Version
> 
> 
> We do have it as a requirement in pyproject.toml though, shouldn't that be
> enough?
> 

There are tiers of dependencies.

The ones called out in pyproject.toml currently only document the dependencies necessary to build the package.

There are also runtime dependencies for the gpiod bindings in general (which I do not believe there are any dependencies on third party libraries) and then there are runtime dependencies for running the tests for the gpiod bindings. Based on these two patches, the runtime dependencies for the tests would include packaging and setuptools>60.2.0. 

The tests builder does not prepare an environment with these dependencies, it just assumes they are available in the base distribution.

A way to work around this would be to prep an environment with the dependencies and have it activated at the time of configure or have the build_tests.py wrapper potentially construct it.

I'm just trying to take into consideration that there may be potential contributors that are doing development on major distributions (not Yocto) and run into these issues which may not be straightforward.

Maybe for now we can call this out in the readme or something?




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux