Re: [PATCH] gpio: gpio-exar: replace division condition with direct comparison

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Fri, Nov 15, 2024 at 12:55 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> Uh, I had to think back...  I had forgotten that I actually published that
> check.  I can unpublish it.
>
> I wrote it based on a real issue, and then when I looked at the warnings quite
> a few places wrote code like "if (x / 4)" where they had intended to write if
> if ((x % 4) == 0).  So it seemed like a good idea.
>
> But in the two years since I published the warning, it has mostly been false
> positives.
>
> regards,
> dan carpenter
>

Ok, I dropped this patch from my queue. I typically trust smatch so I
picked it up without giving it much thought.

Bart