Re: [PATCH 143/182] powerpc: mpc52xx_gpt: use gpiochip data pointer

[Michael Welling <mwelling@xxxxxxxx>]

On Sun, Dec 13, 2015 at 10:02:20PM +0100, Linus Walleij wrote:
> On Thu, Dec 10, 2015 at 12:27 AM, Michael Welling <mwelling@xxxxxxxx> wrote:
> > On Wed, Dec 09, 2015 at 02:41:06PM +0100, Linus Walleij wrote:
> >> @@ -354,7 +349,7 @@ mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_priv *gpt, struct device_node *node)
> >>       clrsetbits_be32(&gpt->regs->mode, MPC52xx_GPT_MODE_MS_MASK,
> >>                       MPC52xx_GPT_MODE_MS_GPIO);
> >>
> >> -     rc = gpiochip_add(&gpt->gc);
> >> +     rc = gpiochip_add_data(&gpt->gc, gpt);
> >>       if (rc)
> >
> > Another place that dev_err references gpiochip_add instead of gpiochip_add_data.
> >
> >>               dev_err(gpt->dev, "gpiochip_add() failed; rc=%i\n", rc);
> 
> OK fixed it.

Sorry for nit picking.

The series otherwises looks good.

Reviewed-by: Michael Welling <mwelling@xxxxxxxx>

> 
> Yours,
> Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html