On Mon, Nov 11, 2024 at 9:54 AM ot907280 <ot_cathy.xu@xxxxxxxxxxxx> wrote: > From: Guodong Liu <guodong.liu@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > > Add register address for each pin config. > Add the function for each pin. > > Signed-off-by: Guodong Liu <guodong.liu@xxxxxxxxxxxx> > Cathy Xu <ot_cathy.xu@xxxxxxxxxxxx> This looks fine, but there are no device tree bindings for mt8196? What do you expect me to do here, I can't merge a device tree based driver for a hardware without DT bindings. Yours, Linus Walleij