Re: [PATCH 030/182] gpio: lpc18xx: use gpiochip data pointer

[Joachim Eastwood <manabian@xxxxxxxxx>]

On 9 December 2015 at 14:16, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: Joachim Eastwood <manabian@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Acked-by: Joachim Eastwood <manabian@xxxxxxxxx>


> Joachim: this driver looks very simplistic, it seems it can
> be totally replaced with drivers/gpio/gpio-generic.c provided
> that some (optional) clock handling is added to the generic GPIO
> driver, if you have some time, please look into that.

I don't think gpio-generic supports one big gpio namespace of 256
gpios which this driver uses.


regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html