Hi,
On Mon, Nov 11, 2024 at 10:34:12AM +0800, Ye Zhang wrote:
> Since the GPIO can only generate interrupts when its direction is set to
> input, it is set to input before requesting the interrupt resources.
>
> Signed-off-by: Ye Zhang <ye.zhang@xxxxxxxxxxxxxx>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
-- Sebastian
> drivers/gpio/gpio-rockchip.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index b7a43e492965..40c2476699aa 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -476,8 +476,11 @@ static int rockchip_irq_reqres(struct irq_data *d)
> {
> struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
> struct rockchip_pin_bank *bank = gc->private;
> + irq_hw_number_t hwirq = irqd_to_hwirq(d);
>
> - return gpiochip_reqres_irq(&bank->gpio_chip, d->hwirq);
> + rockchip_gpio_direction_input(&bank->gpio_chip, hwirq);
> +
> + return gpiochip_reqres_irq(&bank->gpio_chip, hwirq);
> }
>
> static void rockchip_irq_relres(struct irq_data *d)
> --
> 2.34.1
>
>
Attachment:
signature.asc
Description: PGP signature
