Hi,
On Mon, Nov 11, 2024 at 10:34:09AM +0800, Ye Zhang wrote:
> Remove redundant comments and provide a detailed explanation of the
> GPIO version ID.
>
> Signed-off-by: Ye Zhang <ye.zhang@xxxxxxxxxxxxxx>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
-- Sebastian
> drivers/gpio/gpio-rockchip.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index 365ab947983c..71672d654491 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -26,9 +26,15 @@
> #include "../pinctrl/core.h"
> #include "../pinctrl/pinctrl-rockchip.h"
>
> +/*
> + * Version ID Register
> + * Bits [31:24] - Major Version
> + * Bits [23:16] - Minor Version
> + * Bits [15:0] - SVN Number
> + */
> #define GPIO_TYPE_V1 (0) /* GPIO Version ID reserved */
> -#define GPIO_TYPE_V2 (0x01000C2B) /* GPIO Version ID 0x01000C2B */
> -#define GPIO_TYPE_V2_1 (0x0101157C) /* GPIO Version ID 0x0101157C */
> +#define GPIO_TYPE_V2 (0x01000C2B)
> +#define GPIO_TYPE_V2_1 (0x0101157C)
>
> static const struct rockchip_gpio_regs gpio_regs_v1 = {
> .port_dr = 0x00,
> --
> 2.34.1
>
>
Attachment:
signature.asc
Description: PGP signature
