Re: [PATCH] pinctrl: mediatek: Add support for MT8196

[Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>]

Le 11/11/2024 à 09:53, ot907280 a écrit :
> From: Guodong Liu <guodong.liu@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> Add register address for each pin config.
> Add the function for each pin.
>
> Signed-off-by: Guodong Liu <guodong.liu@xxxxxxxxxxxx>
> Cathy Xu <ot_cathy.xu@xxxxxxxxxxxx>
> ---

Hi,

> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt8196.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8196.h
> new file mode 100644
> index 000000000000..9732ede74d9b
> --- /dev/null
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt8196.h
> @@ -0,0 +1,2791 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2024 Mediatek Inc.
> + * Author: Guodong Liu <Guodong.Liu@xxxxxxxxxxxx>
> + *
> + */
> +
> +#ifndef __PINCTRL_MTK_MT8196_H
> +#define __PINCTRL_MTK_MT8196_H
> +

...

> +	MTK_PIN(
> +		292, "veint292",
> +		MTK_EINT_FUNCTION(0, 292),
> +		DRV_GRP4,
> +		MTK_FUNCTION(0, NULL)
> +	)
> +};
> +
> +#endif /* __PINCTRL__MTK_MT8196_H */

Nitpick: there is an extra _ before MTK here.