Re: [PATCH 1/6] gpio: make the gpiochip a real device

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Dec 4, 2015 at 11:31 PM, Michael Welling <mwelling@xxxxxxxx> wrote:
> On Thu, Dec 03, 2015 at 03:06:48PM +0100, Linus Walleij wrote:
>> On Thu, Dec 3, 2015 at 3:04 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>>
>> > 3-1. Split gpio_chip in a static descriptor with a vtable for callbacks
>> >    and other static config called struct gpio_chip, and
>> >    struct gpio_device that is returned as a pointer from
>> >    gpiochip_add(). It will need to be free:ed by gpiodevice_remove()
>> >    after that.
>>
>> This will look something like this uglyhack:
>> https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/commit/?h=gpiochip-desc&id=610b19c1832acfdf6ff62523addfa08b76f77343
>>
>
> Still quite a few place where a gpio_device is being access as if a gpio_chip:
> gpio_device_set_desc_names
> gpio_device_set_multiple
> gpiod_hog
> gpio_device_free_hogs
> gpiolib_dbg_show
> gpiolib_seq_show
> ..
>
> There is still some calls to gpiod_to_chip which was changed to gpiod_to_device.
> gpiod_hog
> ..
>
> The gpiochip_add function prototype was changed in the header but the definition did not change.
>
> Lots of work to do still. Let me know if and how I can help.

Yeah it doesn't even compile. It was more to illustrate.

I am now figuring out how to proceed after merging 187 patches
removing the use of container_of() from all GPIO drivers.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html