Re: [PATCH v1 1/1] gpiolib: Deduplicate gpiod_direction_input_nonotify() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 1, 2024 at 9:15 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Thu, Oct 31, 2024 at 08:14:56PM +0100, Bartosz Golaszewski wrote:
> > On Thu, Oct 31, 2024 at 10:22 AM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> ...
>
> > >  set_output_flag:
> >
> > Ok, I'll take it but please change this label to "emulate_output" or
> > something similar that's more indicative on what the goal here is.
>
> It's out of scope of this patch.
>

It is not though. You are already touching this code, make it even better.

Just say in the commit message: "while at it, rename the label to ..."

Bartosz





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux