On Wed, Oct 30, 2024 at 01:12:01PM -0400, Mary Strodl wrote: > On Wed, Oct 30, 2024 at 05:30:26PM +0200, Andy Shevchenko wrote: ... > > + err = devm_mutex_init(dev, &priv->io_mutex); > > + if (err) > > + return err; > > + > > + ret = devm_mutex_init(dev, &priv->irq_mutex); > > I think this should be `err = ` Oh, I haven't compiled that for sure :-) > Other than that, it looks good to me (I doubt you need this, but just in case): > > Reviewed-by: Mary Strodl <mstrodl@xxxxxxxxxxx> Thanks, I will fix that, I dunno how I missed that because I carefully read the code before adding the checks. -- With Best Regards, Andy Shevchenko