Re: [PATCH] gpio: pca953x: make inclusion of <linux/of_platform.h> unconditional

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Dec 9, 2015 at 11:53 AM, Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote:
> On 09/12/15 10:06, Linus Walleij wrote:
>> After adding the DT matching in
>> commit 6f29c9afbe636fc0e35c82a11eaf45c3b85eb07a
>> "gpio: pca935x: fix of-only probed devices"
>> compilation fails like this:
>>
>> CC [M]  drivers/gpio/gpio-pca953x.o
>> gpio-pca953x.c: In function ‘pca953x_probe’:
>> gpio-pca953x.c:693:11: error: implicit declaration of
>> function ‘of_match_device’ [-Werror=implicit-function-declaration]
>> match = of_match_device(pca953x_dt_ids, &client->dev);
>
> Thanks, given the driver makes no other attempt to remove OF
> lists if there is no OF present then this may as well be
> unconditionally included.

Hm it seems to fail compilation on a few defconfigs still...
Need to think about adding deps or reintroducing these ifdefs.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html