Re: [PATCH v3 01/12] dt-bindings: pinctrl: fsl,imx6ul-pinctrl: Convert i.MX35/5x/6 to YAML

[Marek Vasut <marex@xxxxxxx>]

On 10/22/24 5:25 AM, Shawn Guo wrote:
> On Thu, Oct 17, 2024 at 11:11:18PM +0200, Marek Vasut wrote:
> > The IOMUXC controller description is almost identical on i.MX35/5x/6 SoCs,
> > except for the configuration bits which differ across SoCs. Rename the
> > fsl,imx6ul-pinctrl.yaml to fsl,imx35-pinctrl.yaml, fill in compatible
> > strings for the other SoCs and fill in the various bits into desciption.
> > This way, i.MX35/5x/6 series SoCs can all be converted to DT schema.
> > Remove the old text DT bindings description.
> >
> > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > Signed-off-by: Marek Vasut <marex@xxxxxxx>
> > ---
> > Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> > Cc: Dong Aisheng <aisheng.dong@xxxxxxx>
> > Cc: Fabio Estevam <festevam@xxxxxxxxx>
> > Cc: Jacky Bai <ping.bai@xxxxxxx>
> > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> > Cc: Stefan Wahren <wahrenst@xxxxxxx>
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: imx@xxxxxxxxxxxxxxx
> > Cc: kernel@xxxxxxxxxxxxxxxxxx
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: linux-gpio@xxxxxxxxxxxxxxx
> > ---
> > V2: - Use DT schema to refer to the fsl,imx35-pinctrl.yaml file
> >      - Special-case the iMX50 compatible string
> > V3: Add RB from Rob
> > ---
> >   .../bindings/pinctrl/fsl,imx35-pinctrl.txt    | 33 -------
> >   ...ul-pinctrl.yaml => fsl,imx35-pinctrl.yaml} | 88 ++++++++++++++++---
> >   .../bindings/pinctrl/fsl,imx50-pinctrl.txt    | 32 -------
> >   .../bindings/pinctrl/fsl,imx51-pinctrl.txt    | 32 -------
> >   .../bindings/pinctrl/fsl,imx53-pinctrl.txt    | 32 -------
> >   .../bindings/pinctrl/fsl,imx6dl-pinctrl.txt   | 38 --------
> >   .../bindings/pinctrl/fsl,imx6q-pinctrl.txt    | 38 --------
> >   .../bindings/pinctrl/fsl,imx6sl-pinctrl.txt   | 39 --------
> >   .../bindings/pinctrl/fsl,imx6sll-pinctrl.txt  | 40 ---------
> >   .../bindings/pinctrl/fsl,imx6sx-pinctrl.txt   | 36 --------
> >   10 files changed, 78 insertions(+), 330 deletions(-)
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx35-pinctrl.txt
> >   rename Documentation/devicetree/bindings/pinctrl/{fsl,imx6ul-pinctrl.yaml => fsl,imx35-pinctrl.yaml} (50%)
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx50-pinctrl.txt
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx51-pinctrl.txt
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx53-pinctrl.txt
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6dl-pinctrl.txt
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6q-pinctrl.txt
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6sl-pinctrl.txt
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6sll-pinctrl.txt
> >   delete mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx6sx-pinctrl.txt
>
> I'm not sure it makes a lot sense to have "fsl,imx6ul-pinctrl: " in the
> subject prefix.
I can change it to imx-pinctrl or something and send V4 , or can you 
tweak it while applying since the series is somewhat large ? Which do 
you prefer ?