Re: [RFC v7 4/6] gpio: mpfs: add polarfire soc gpio support

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Oct 16, 2024 at 11:56 AM Conor Dooley <conor@xxxxxxxxxx> wrote:

> I dunno if I'm making a mistake here, but I don't know if there's much
> value in implementing this suggestion - as far as I can tell only the
> get()/set() functions can be replaced by what's provided by gpio-mmio.c.

You're not making any mistake, you know the driver and hw better
than me.

Just skip the GPIO_MMIO if you think the result would look ugly.

You can add my:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij