Re: [PATCH v2 0/5] Add Exynos990 pinctrl and chipid drivers

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 16/10/2024 09:06, Krzysztof Kozlowski wrote:
> On Tue, Oct 15, 2024 at 11:04:45PM +0200, Igor Belwon wrote:
>> Hi folks,
>>
>> This series adds support for the drivers for the Exynos 990 SoC. It
>> consists of the pinctrl driver and the chipid driver. The product ID
>> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
>> same as in the Exynos 850 chip.
>>
>> Changes in v2:
>>  - Moved bindings from SoC bringup commit
>>  - Moved device tree changes from SoC bringup commit
>>  - Ordered pinctrl nodes by unit address in SoC DT
>>  - Moved the exynos990-wakeup-eint binding to the correct if.
> 
> Moved? That's not what I asked for. Are you sure you have this warning
> free? That's a requirement for Samsung (see maintainer profile).

Ah, I see now what you did - you removed the interrupt. That's
surprising. I don't understand why.

Best regards,
Krzysztof