Re: [PATCH v1 5/7] dt-bindings: pinctrl: samsung: add exynos990-wakeup-eint compatible

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 15/10/2024 08:33, Krzysztof Kozlowski wrote:
> On 15/10/2024 08:27, Igor Belwon wrote:
>> Add a dedicated compatible for the exynos990-wakeup-eint node.
>>
>> Signed-off-by: Igor Belwon <igor.belwon@xxxxxxxxxxxxxxxxxxxxxxxxxx>
>> ---
>>  .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml       | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> index 91516fedc872..cda5bf4cee4a 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> @@ -43,6 +43,7 @@ properties:
>>                - samsung,exynos7885-wakeup-eint
>>                - samsung,exynos850-wakeup-eint
>>                - samsung,exynos8895-wakeup-eint
> 
> There is no such line. You must document all dependencies and explain
> why. So far I don't see any reasons for external dependencies. This only
> will restrict the testing and make your patchset wait for very long...

I was wrong, 8895 was already merged.

Best regards,
Krzysztof