Re: [libgpiod][PATCH 20/22] bindings: python: tests: annotate internal members

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Fri, Sep 27, 2024 at 8:57 PM Vincent Fazio <vfazio@xxxxxxxxxxx> wrote:
>
> Signed-off-by: Vincent Fazio <vfazio@xxxxxxxxxxx>
> ---
>  bindings/python/tests/tests_chip.py       | 10 +++++++---
>  bindings/python/tests/tests_chip_info.py  | 13 ++++++++++---
>  bindings/python/tests/tests_edge_event.py | 11 +++++++++--
>  bindings/python/tests/tests_info_event.py | 30 +++++++++++++++++++++++++-----
>  bindings/python/tests/tests_line_info.py  | 13 +++++++++++--
>  5 files changed, 62 insertions(+), 15 deletions(-)
>
> diff --git a/bindings/python/tests/tests_chip.py b/bindings/python/tests/tests_chip.py
> index 89d5df4341eceefbc0eed9b880ac641caa682af5..b719f6ba402c962b3ba8029cef61ed28fd1a525a 100644
> --- a/bindings/python/tests/tests_chip.py
> +++ b/bindings/python/tests/tests_chip.py
> @@ -3,6 +3,7 @@
>
>  import errno
>  import os
> +from typing import Optional
>  from unittest import TestCase
>
>  import gpiod
> @@ -70,7 +71,7 @@ class ChipBooleanConversion(TestCase):
>
>  class ChipProperties(TestCase):
>      def setUp(self) -> None:
> -        self.sim = gpiosim.Chip()
> +        self.sim: Optional[gpiosim.Chip] = gpiosim.Chip()
>          self.chip = gpiod.Chip(self.sim.dev_path)
>
>      def tearDown(self) -> None:
> @@ -78,6 +79,7 @@ class ChipProperties(TestCase):
>          self.sim = None
>
>      def test_get_chip_path(self) -> None:
> +        assert self.sim

Please say in the commit message why this is needed because I don't
understand this line and others below.

Bart