On Fri, Sep 27, 2024 at 8:57 PM Vincent Fazio <vfazio@xxxxxxxxxxx> wrote: > > Remove `_check_line_name` in favor of a new function, `_line_to_offset`, > that converts a line reference to an offset. > > This new function helps narrow types and simplifies the iteration logic > that is used to build objects to interface with `_ext.Request`. > > Signed-off-by: Vincent Fazio <vfazio@xxxxxxxxxxx> > --- Looks good. Bart
Re: [libgpiod][PATCH 10/22] bindings: python: convert lines to offsets in LineRequest
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [libgpiod][PATCH 10/22] bindings: python: convert lines to offsets in LineRequest
- From: Bartosz Golaszewski <brgl@xxxxxxxx>
- Date: Tue, 8 Oct 2024 15:19:52 +0200
- In-reply-to: <20240927-vfazio-mypy-v1-10-91a7c2e20884@xes-inc.com>
- References: <20240927-vfazio-mypy-v1-0-91a7c2e20884@xes-inc.com> <20240927-vfazio-mypy-v1-10-91a7c2e20884@xes-inc.com>
- References:
- Prev by Date: Re: [libgpiod][PATCH 09/22] bindings: python: fix LineRequest union-attr type errors
- Next by Date: Re: [libgpiod][PATCH 11/22] bindings: python: cast return value of LineRequest.get_values
- Previous by thread: [libgpiod][PATCH 10/22] bindings: python: convert lines to offsets in LineRequest
- Next by thread: [libgpiod][PATCH 11/22] bindings: python: cast return value of LineRequest.get_values
- Index(es):
 |