On 07/10/2024 18:02, Rob Herring (Arm) wrote:
On Mon, 07 Oct 2024 16:16:25 +0200, Neil Armstrong wrote:While converting the Amlogic Meson pinctrl binding to dt-schema, the mandatory reg property for Meson8/b aobus pinctrl node was ommited, fix this to finally pass all bindings checks. Fixes: 94df03a45276 ("dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding") Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> --- .../pinctrl/amlogic,meson8-pinctrl-aobus.yaml | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-)My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/amlogic,meson8-pinctrl-aobus.example.dtb: pinctrl: 'reg' is a required property from schema $id: http://devicetree.org/schemas/pinctrl/amlogic,meson8-pinctrl-aobus.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241007-topic-amlogic-arm32-upstream-bindings-fixes-meson8-pinctrl-v1-1-d3d838540033@xxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Right, I thought I tested those bindings, but seems I missed something... Thanks, Neil
