Re: [PATCH 2/3] pinctrl: renesas: rzg2l: Add support for configuring open-drain outputs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thank you for the review.

On Fri, Oct 4, 2024 at 8:56 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Wed, Sep 18, 2024 at 2:09 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Add support for configuring the multiplexed pins as open-drain outputs.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
>
> > @@ -1466,6 +1477,13 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
> >                         rzg2l_rmw_pin_config(pctrl, IOLH(off), bit, IOLH_MASK, index);
> >                         break;
> >
> > +               case PIN_CONFIG_DRIVE_OPEN_DRAIN:
> > +                       if (!(cfg & PIN_CFG_NOD))
> > +                               return -EINVAL;
> > +
> > +                       rzg2l_rmw_pin_config(pctrl, NOD(off), bit, NOD_MASK, 1);
> > +                       break;
> > +
>
> I think you also need a case for PIN_CONFIG_DRIVE_PUSH_PULL,
> so you can disable the NOD bit again.
>
Ok, I will implement PIN_CONFIG_DRIVE_PUSH_PULL to disable open drain
and send a v2.

Cheers,
Prabhakar





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux