Re: [PATCH] pinctrl: renesas: rzg2l: Fix missing return statement

[Sergey Shtylyov <s.shtylyov@xxxxxx>]

On 10/3/24 10:53, Biju Das wrote:

> Fix the missing return statement on the error path for
> rzg2l_pinctrl_register().
> 
> Fixes: f73f63b24491 ("pinctrl: renesas: rzg2l: Use dev_err_probe()")
> Reported-by: nobuhiro1.iwamatsu@xxxxxxxxxxxxx <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>

   Hm, strange email?

> Closes: https://lore.kernel.org/all/OS0PR01MB638837327E5487B71D88A70392712@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
>  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index 5a403915fed2..f913e8385ead 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -2710,7 +2710,7 @@ static int rzg2l_pinctrl_register(struct rzg2l_pinctrl *pctrl)
>  
>  	ret = pinctrl_enable(pctrl->pctl);
>  	if (ret)
> -		dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n");
> +		return	dev_err_probe(pctrl->dev, ret, "pinctrl enable failed\n");

   Why tab after *return*?

[...]

MBR, Sergey