On Fri, Sep 27, 2024 at 9:42 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > For drivers or board files that set gpio_chip->names, the links to the > GPIO attribute group created on sysfs export will be named after the > line's name set in that array. For lines that are named using device > properties, the names pointer of the gpio_chip struct is never assigned > so they are exported as if they're not named. > > The ABI documentation does not mention the former behavior and given > that the majority of modern systems use device-tree, ACPI or other way > of passing GPIO names using device properties - bypassing gc->names - > it's better to make the behavior consistent by always exporting lines as > "gpioXYZ". > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> I'm in favor of this. Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Story time: That's a good story :) Fun to see how you arrived at this. Yours, Linus Walleij