Re: [libgpiod][PATCH] bindings: python: tests: skip some reconfigure tests on older kernels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 23, 2024 at 8:27 PM Vincent Fazio <vfazio@xxxxxxxxx> wrote:
>
> Commit 40db20e added tests to ensure that lines that were either missing
> from a reconfigure call or were included but had no LineSettings defined
> would _not_ change configuration.
>
> However, this functionality requires the changes from kernel commit
> b44039638 to work as expected. This commit exists in the 6.10 kernel and
> was backported to 6.9.8 [0].
>
> Now, these tests are skipped if the kernel version is older than 6.9.8.
>
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d972e7b24a50d1f89967d5bffc3147810af9222d
> Fixes: 40db20eec045 ("bindings: python: tests: extend reconfiguration tests")
> Signed-off-by: Vincent Fazio <vfazio@xxxxxxxxxxx>
> ---

As discussed on github: I prefer the older stable kernel branches to
have the relevant patch from Kent backported than to start adding this
kind of unmaintainable ifdiffery to tests. I see Greg already started
picking up the backports so let's drop this for now.

Bart





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux