On Mon, Sep 23, 2024 at 12:44:15AM +0200, Linus Walleij wrote: > Maybe you want to provide the gpio.names array for this > device? > > It makes it easier to use the lines from userspace if they > have meaningful names, it looks like those may be printed > on the board on the Sealevel device. There are a bunch of devices using this chip in very different ways, so I didn't want to tie it too closely to this specific device. Also this device kinda doesn't have a good way to label the pins. Part of the issue is that sealevel hasn't given us a schematic of how the chip is connected, I've had to figure stuff out by trial and error... :S > Yours, > Linus Walleij Thanks for reviewing! I'll have a new patch out soon with the feedback from your previous email addressed :)