Hi, >> +#define SIUL2_PGPDO(N) (((N) ^ 1) * 2) >> +#define S32G2_SIUL2_NUM 2 >> +#define S32G2_PADS_DTS_TAG_LEN (7) > nit: Parentheses are not required here, please remove it. Thank you for the review! I will remove the parentheses from "S32G2_PADS_DTS_TAG_LEN" in v4. Best regards, Andrei
Re: [PATCH v3 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v3 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support
- From: Andrei Stefanescu <andrei.stefanescu@xxxxxxxxxxx>
- Date: Mon, 23 Sep 2024 13:57:42 +0300
- In-reply-to: <690a7534-9f15-4220-9edf-ca56203c7fa0@marvell.com>
- References: <20240919134732.2626144-1-andrei.stefanescu@oss.nxp.com> <20240919134732.2626144-4-andrei.stefanescu@oss.nxp.com> <690a7534-9f15-4220-9edf-ca56203c7fa0@marvell.com>
- User-agent: Mozilla Thunderbird
- References:
- [PATCH v3 0/4] gpio: siul2-s32g2: add initial GPIO driver
- From: Andrei Stefanescu
- [PATCH v3 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support
- From: Andrei Stefanescu
- [PATCH v3 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support
- From: Amit Singh Tomar
- [PATCH v3 0/4] gpio: siul2-s32g2: add initial GPIO driver
- Prev by Date: Re: [PATCH v3 2/4] dt-bindings: gpio: add support for NXP S32G2/S32G3 SoCs
- Next by Date: Re: [PATCH v2] gpio: free irqs that are still requested when the chip is being removed
- Previous by thread: [PATCH v3 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support
- Next by thread: [PATCH v3 4/4] MAINTAINERS: add MAINTAINER for S32G2 SIUL2 GPIO driver
- Index(es):
 |