Re: [PATCH v1 1/1] pinctrl: nomadik: Use string_choices API instead of ternary operator

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Sep 5, 2024 at 2:56 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> On Mon, Aug 26, 2024 at 12:57:23PM +0300, Andy Shevchenko wrote:

> > Use modern string_choices API instead of manually determining the
> > output using ternary operator.
>
> Linus, do you have any comment on this?
>
> I had sent two patches of similar changes (different drivers, thoug),
> one got applied and this is not. Anything should I do about it?

Sorry for late reply :(

I thought it looks weird to replace just one string choice
in the middle of everything and it will be confusing for readers?
They will be "but what is this now, this looks weird".

Yours,
Linus Walleij