Re: [PATCH v4 08/10] arm64: dts: exynos: Add initial support for exynos8895 SoC

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 18/09/2024 19:54, Ivaylo Ivanov wrote:
>>> +		cpu3: cpu@103 {
>>> +			device_type = "cpu";
>>> +			compatible = "arm,cortex-a53";
>>> +			reg = <0x103>;
>>> +			enable-method = "psci";
>>> +		};
>>> +
>>> +		cpu4: cpu@0 {
>> Why cpu@0 is cpu4 not cpu0? Anyway, these should be ordered by unit
>> address.
> 
> cpu@100 is the boot core of the first cluster consisting of cortex-a53
> 
> cores, hence why it's labelled as cpu0. The second cluster contains
> 
> the Mongoose cores, labelled and ordered after the first cluster.
> 
> 
> It's ordered like so on a lot of SoCs for sanity's sake, hence why I
> 
> believe it should stay like that.

I tend to switch to style expressed in DTS coding style, especially that
we might use at some point sorting tool which would then need exception
for CPUs. Keep existing labels, assuming they reflect reality, but order
by unit address.

> 
> 
> If you still think that they must be ordered by unit address, please
> 
> explicitly let me know so that I include that change in the v5.
> 


Best regards,
Krzysztof