Re: [PATCH v2 4/4] MAINTAINERS: add MAINTAINER for S32G2 SIUL2 GPIO driver

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 18/09/2024 09:57, Andrei Stefanescu wrote:
> Hi Krzysztof,
> 
> On 17/09/2024 20:44, Krzysztof Kozlowski wrote:
>> On 13/09/2024 10:29, Andrei Stefanescu wrote:
>>> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@xxxxxxxxxxx>
>>> ---
>>>  MAINTAINERS | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 10430778c998..e23c4369b6e1 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2689,10 +2689,12 @@ ARM/NXP S32G ARCHITECTURE
>>>  R:	Chester Lin <chester62515@xxxxxxxxx>
>>>  R:	Matthias Brugger <mbrugger@xxxxxxxx>
>>>  R:	Ghennadi Procopciuc <ghennadi.procopciuc@xxxxxxxxxxx>
>>> +R: 	Andrei Stefanescu <andrei.stefanescu@xxxxxxxxxxx>
>>
>> That's another patch where NXP adds silently themself as platform
>> maintainer without explanation. Although here at least existing
>> maintainers are Cced.
>>
>> This looks like some pattern, so maybe clarifications are needed.
>>
>> You wanted to be maintainer of this driver alone, right? So separate entry.
> 
> I would actually want to become a maintainer for the platform. I have
> already added changes to the pinctrl driver and the s32g2.dtsi/s32g3.dtsi files.
> I intend to submit more patches to these files and I would like to review
> changes to them.

That's fine, so please provide some sort of message in the commit,
describing your intention, document the commitment.

> 
> However, if you or any of the existing maintainers consider that I should
> only add myself as a maintainer for the SIUL2 GPIO driver, I can fix this in v3.

I assume you proposed this after consulting them? It is unusual to add
yourself to maintainers without first talking to existing folks...


Best regards,
Krzysztof