On 16/9/2024 22:39, Krzysztof Kozlowski wrote: > On Sun, Sep 15, 2024 at 03:59:03PM +0800, Nick Chan wrote: >> From: Konrad Dybcio <konradybcio@xxxxxxxxxx> >> >> Add DTS files for the A10X SoC and the following devices based on it: >> >> - Apple TV 4K >> - iPad Pro (2nd Generation) (10.5 Inch) >> - iPad Pro (2nd Generation) (12.9 Inch) >> >> Signed-off-by: Konrad Dybcio <konradybcio@xxxxxxxxxx> >> [Nick: SMP, m1n1 and Apple TV 4K support, uart interrupt and pinctrl fixes] >> Co-developed-by: Nick Chan <towinchenmi@xxxxxxxxx> >> Signed-off-by: Nick Chan <towinchenmi@xxxxxxxxx> >> --- >> .../devicetree/bindings/arm/apple.yaml | 8 +- > > You need to split bindings. Good catch. The bindings part needs to be squashed into the commit adding the bindings. This is a miscommited style fix up to not mention "Apple" when we are already in Apple ARM Machine bindings, unless it is part of the offical name (like Apple TV). > > Best regards, > Krzysztof > Nick Chan