Re: [PATCH v1 1/1] gpiolib: cdev: use !mem_is_zero() instead of memchr_inv(s, 0, n)

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Sep 5, 2024 at 3:01 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Thu, Sep 05, 2024 at 09:36:20AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> >
> > On Wed, 04 Sep 2024 12:07:43 +0300, Andy Shevchenko wrote:
> > > Use the mem_is_zero() helper where possible.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [1/1] gpiolib: cdev: use !mem_is_zero() instead of memchr_inv(s, 0, n)
> >       commit: b1da870ba36b3f525aee9be35b2f08a1feec61a7
> >
>
> As per my other mail, mem_is_zero() is not defined in gpio/for-next yet.
> So how does this work?
>
> If I build for-next I get:
>
> drivers/gpio/gpiolib-cdev.c: In function ‘gpio_v2_line_config_validate’:
> drivers/gpio/gpiolib-cdev.c:1334:14: error: implicit declaration of function ‘mem_is_zero’; did you mean ‘xa_is_zero’? [-Werror=implicit-function-declaration]
>  1334 |         if (!mem_is_zero(lc->padding, sizeof(lc->padding)))
>       |              ^~~~~~~~~~~
>       |              xa_is_zero
>
>
> Cheers,
> Kent.

Ah, it'll have to wait until the next release cycle then. Sorry for
vacuuming patches too eagerly today. Dropping it.

Bart