Re: [PATCH v1 1/5] gpio: stmpe: Fix IRQ related error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 2, 2024 at 3:32 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> First of all, remove duplicate message that platform_get_irq()
> does already print. Second, correct the error message when unable
> to register a handler, which is broken in two ways:
> 1) the misleading 'get' vs. 'register';
> 2) missing '\n' at the end.
>
> (Yes, for the curious ones, the dev_*() cases do not require '\n'
> and issue it automatically, but it's better to have them explicit)
>
> Fix all this here.
>
> Fixes: 1882e769362b ("gpio: stmpe: Simplify with dev_err_probe()")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux