Re: [libgpiod][PATCH] build: imply --enable-bindings-glib for --enable-dbus

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Wed, Sep 4, 2024 at 1:29 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Tue, Sep 03, 2024 at 11:53:57AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > GLib bindings are required to build the D-Bus daemon. Enable them
> > automatically if --enable-dbus is passed to configure.
> >
> > Fixes: a5ab76da1e0a ("dbus: add the D-Bus daemon, command-line client and tests")
> > Reported-by: Douglas Silva <doug.hs@xxxxxxxxx>
> > Suggested-by: Kent Gibson <warthog618@xxxxxxxxx>
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> This does not work for me.
> Using both --enable-dbus and --enable-bindings-glib works, but only
> specifying --enable-dbus results in:
>
> make[3]: Entering directory '/home/dev/libgpiod/dbus/lib'
>   GEN      generated-gpiodbus.c
> make  all-am
> make[4]: Entering directory '/home/dev/libgpiod/dbus/lib'
>   CC       libgpiodbus_la-generated-gpiodbus.lo
> In file included from generated-gpiodbus.c:13:
> generated-gpiodbus.h:12:10: fatal error: gio/gio.h: No such file or directory
>    12 | #include <gio/gio.h>
>       |          ^~~~~~~~~~~
> compilation terminated.
>
> It isn't propagating the glib dependency that populates the
> GLIB_CFLAGS and so the include paths.
>
> That is on Debian testing, btw.
>

Hmm, weird, I remember testing this as the first thing but it doesn't
work indeed. Maybe I had a dirty build dir. I'll look into it.

Bart