Re: [PATCH 1/3] dt-bindings: gpio: spacemit: add support for K1 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/09/2024 09:05, Yixun Lan wrote:
> Hi Krzysztof 

>>> +  "#interrupt-cells":
>>> +    const: 2
>>> +    description: |
>>> +      The first cell is the GPIO number, the second should specify
>>> +      flags.  The following subset of flags is supported:
>>> +      - bits[3:0] trigger type flags (no level trigger type support)
>>> +        1 = low-to-high edge triggered
>>> +        2 = high-to-low edge triggered
>>> +      Valid combinations are 1, 2, 3
>>
>> Hm? No, you must use standard interrupt flags, not custom ones.
>>
> It should be same as standard flags, my intention here was try to say
> the controller support edge trigger only, but no level trigger flags (4, 8)
> should I just replace number to macro, and put it like this:

Then just say that level interrupts are not supported. Do not refer to
some bits (bits of what?).

Best regards,
Krzysztof





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux