On Tue, Sep 03, 2024 at 05:45:33PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Use the preferred API for assigning system sleep pm callbacks in drivers. > > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> Hmm... Maybe I should pay more attention when answering emails. Please, use my @linux.intel.com address for Linux kernel contributions. ... > #include <linux/mod_devicetable.h> > #include <linux/of.h> > #include <linux/platform_device.h> > +#include <linux/pm_runtime.h> You need pm.h as macros defined there. > #include <linux/property.h> > #include <linux/slab.h> > #include <linux/spinlock.h> ... > +static DEFINE_RUNTIME_DEV_PM_OPS(mpc8xx_pm_ops, mpc8xxx_suspend, > + mpc8xxx_resume, NULL); I would split logically, i.e. static DEFINE_RUNTIME_DEV_PM_OPS(mpc8xx_pm_ops, mpc8xxx_suspend, mpc8xxx_resume, NULL); OR static DEFINE_RUNTIME_DEV_PM_OPS(mpc8xx_pm_ops, mpc8xxx_suspend, mpc8xxx_resume, NULL); -- With Best Regards, Andy Shevchenko