On Tue, Sep 03, 2024 at 03:36:41PM +0800, Ye Zhang wrote:
> div_reg may be < 0 if debounce is zero, causing the unsigned int to
> overflow.
...
> - if (bank->gpio_type == GPIO_TYPE_V2 && !IS_ERR(bank->db_clk)) {
> + if ((bank->gpio_type == GPIO_TYPE_V2) && !IS_ERR(bank->db_clk))
Stray change.
--
With Best Regards,
Andy Shevchenko
Re: [PATCH v3 04/12] gpio: rockchip: resolve underflow issue
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v3 04/12] gpio: rockchip: resolve underflow issue
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Tue, 3 Sep 2024 18:55:01 +0300
- In-reply-to: <20240903073649.237362-5-ye.zhang@rock-chips.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20240903073649.237362-1-ye.zhang@rock-chips.com> <20240903073649.237362-5-ye.zhang@rock-chips.com>
- References:
- [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver
- From: Ye Zhang
- [PATCH v3 04/12] gpio: rockchip: resolve underflow issue
- From: Ye Zhang
- [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver
- Prev by Date: Re: [PATCH v3 01/12] gpio: rockchip: avoid division by zero
- Next by Date: Re: [PATCH v3 07/12] gpio: rockchip: support 'clock-names' from dt nodes
- Previous by thread: [PATCH v3 04/12] gpio: rockchip: resolve underflow issue
- Next by thread: [PATCH -next] pinctrl: Remove redundant null pointer checks in pinctrl_remove_device_debugfs()
- Index(es):
 |