Re: [PATCH 4/6] pinctrl: ls1046a: Add pinctrl driver support

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Aug 27, 2024 at 9:20 PM Frank Li <Frank.li@xxxxxxx> wrote:
> On Tue, Aug 27, 2024 at 12:12:24PM +1000, David Leonard wrote:
> >
> > Add QorIQ LS1046A pinctrl driver allowing i2c-core to exert
> > GPIO control over the third and fourth I2C buses.
> >
> > Signed-off-by: David Leonard <David.Leonard@xxxxxxxx>
> > ---
>
> Why not use pinctrl-single,  please ref fsl,lx2160x.dtsi for GPIO/i2c
> recover.

I'm not so sure about that. Since the 1012 need to use a unique
driver this will be confusing across the family: one chip has
registers and values defined in the device tree, another has
them in the driver, if possible I would advice to keep this
consistent across sibling SoCs.

I can't stop anyone from using pinctrl-single but it's a bit
seductive in it's simplicity, while not always so user-friendly
with all the magic that ends up in the device trees.

Yours,
Linus Walleij