On Wed, Aug 28 2024 at 13:27, Charles Keepax wrote: > On Wed, Aug 28, 2024 at 08:01:18PM +0800, Yan Zhen wrote: >> @@ -1064,10 +1064,9 @@ static int madera_pin_probe(struct platform_device *pdev) >> ret = pinctrl_register_mappings(pdata->gpio_configs, >> pdata->n_gpio_configs); >> if (ret) { >> - dev_err(priv->dev, >> - "Failed to register pdata mappings (%d)\n", >> - ret); >> - return ret; >> + return dev_err_probe(priv->dev, ret, >> + "Failed to register pdata mappings (%d)\n", >> + ret); >> } > > Since we are doing a respin anyway also the brackets on the if > should be dropped on both of these as well. No. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules Thanks, tglx