Re: [PATCH 6/6] dt-bindings: pinctrl: Add fsl,ls1046a-pinctrl yaml file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 27, 2024 at 12:15:08PM +1000, David Leonard wrote:
> 

Why do you keep sending emails one-by-one?

Fix your threading.

All previous comments apply.

> Add a binding schema and examples for the LS1046A's pinctrl function.
> 
> Signed-off-by: David Leonard <David.Leonard@xxxxxxxx>
> ---
>  .../bindings/pinctrl/fsl,ls1046a-pinctrl.yaml | 74 +++++++++++++++++++
>  1 file changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml
> new file mode 100644
> index 000000000000..3d49e42d33e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/fsl,ls1046a-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP QorIQ LS1046A pin multiplexing
> +
> +maintainers:
> +  - David.Leonard@xxxxxxxx
> +
> +description: >
> +  Bindings for LS1046A pinmux control.
> +
> +properties:
> +  compatible:
> +    const: fsl,ls1046a-pinctrl
> +
> +  reg:
> +    description: >

Drop >, actually entire description... insteasd list and describe the
items.

> +      Specifies the base address of SCFG_RCWPMUXCR0
> +    maxItems: 2
> +
> +  big-endian:
> +    description: >

Drop >

all other comments also apply.

Best regards,
Krzysztof





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux