On Wed, Aug 21, 2024 at 02:49:58PM +0800, Yu Jiaoliang wrote: > Let the kememdup_array() take care about multiplication and possible kmemdup_array() > overflows. ... > + dup_configs = kmemdup_array(configs, num_configs, sizeof(*dup_configs), > + GFP_KERNEL); I would even make this a single line. ... > + dup_configs = kmemdup_array(configs, num_configs, sizeof(*dup_configs), > + GFP_KERNEL); Ditto. -- With Best Regards, Andy Shevchenko
Re: [PATCH v1] pinctrl: nomadik: Use kmemdup_array instead of kmemdup for multiple allocation
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1] pinctrl: nomadik: Use kmemdup_array instead of kmemdup for multiple allocation
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
- Date: Fri, 23 Aug 2024 18:27:38 +0300
- In-reply-to: <20240821064958.4059221-1-yujiaoliang@vivo.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20240821064958.4059221-1-yujiaoliang@vivo.com>
- Follow-Ups:
- References:
- Prev by Date: Re: [PATCH] gpio: pca953x: Print the error code on read/write failures
- Next by Date: Re: [PATCH v1] drivers/pinctrl/renesas: Switch to use kmemdup_array()
- Previous by thread: [PATCH v1] pinctrl: nomadik: Use kmemdup_array instead of kmemdup for multiple allocation
- Next by thread: Re: [PATCH v1] pinctrl: nomadik: Use kmemdup_array instead of kmemdup for multiple allocation
- Index(es):
 |