Re: [PATCH 01/11] dt-bindings: clock: Add RaspberryPi RP1 clock bindings

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 22/08/2024 11:35, Andrea della Porta wrote:
> Hi Conor,
> 
> On 12:46 Wed 21 Aug     , Conor Dooley wrote:
>> On Tue, Aug 20, 2024 at 08:25:36PM +0200, Andrea della Porta wrote:
>>> Hi Conor,
>>>
>>> On 17:19 Tue 20 Aug     , Conor Dooley wrote:
>>>> On Tue, Aug 20, 2024 at 04:36:03PM +0200, Andrea della Porta wrote:
>>>>> Add device tree bindings for the clock generator found in RP1 multi
>>>>> function device, and relative entries in MAINTAINERS file.
>>>>>
>>>>> Signed-off-by: Andrea della Porta <andrea.porta@xxxxxxxx>
>>>>> ---
>>>>>  .../clock/raspberrypi,rp1-clocks.yaml         | 87 +++++++++++++++++++
>>>>>  MAINTAINERS                                   |  6 ++
>>>>>  include/dt-bindings/clock/rp1.h               | 56 ++++++++++++
>>>>>  3 files changed, 149 insertions(+)
>>>>>  create mode 100644 Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
>>>>>  create mode 100644 include/dt-bindings/clock/rp1.h
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml b/Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..b27db86d0572
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
>>>>> @@ -0,0 +1,87 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/clock/raspberrypi,rp1-clocks.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: RaspberryPi RP1 clock generator
>>>>> +
>>>>> +maintainers:
>>>>> +  - Andrea della Porta <andrea.porta@xxxxxxxx>
>>>>> +
>>>>> +description: |
>>>>> +  The RP1 contains a clock generator designed as three PLLs (CORE, AUDIO,
>>>>> +  VIDEO), and each PLL output can be programmed though dividers to generate
>>>>> +  the clocks to drive the sub-peripherals embedded inside the chipset.
>>>>> +
>>>>> +  Link to datasheet:
>>>>> +  https://datasheets.raspberrypi.com/rp1/rp1-peripherals.pdf
>>>>> +
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    const: raspberrypi,rp1-clocks
>>>>> +
>>>>> +  reg:
>>>>> +    maxItems: 1
>>>>> +
>>>>> +  '#clock-cells':
>>>>> +    description:
>>>>> +      The index in the assigned-clocks is mapped to the output clock as per
>>>>> +      definitions in dt-bindings/clock/rp1.h.
>>>>> +    const: 1
>>>>> +
>>>>> +  clocks:
>>>>> +    maxItems: 1
>>>>> +
>>>>> +required:
>>>>> +  - compatible
>>>>> +  - reg
>>>>> +  - '#clock-cells'
>>>>> +  - clocks
>>>>> +
>>>>> +additionalProperties: false
>>>>> +
>>>>> +examples:
>>>>> +  - |
>>>>> +    #include <dt-bindings/clock/rp1.h>
>>>>> +
>>>>> +    rp1 {
>>>>> +        #address-cells = <2>;
>>>>> +        #size-cells = <2>;
>>>>> +
>>>>> +        rp1_clocks: clocks@18000 {
>>>>
>>>> The unit address does not match the reg property. I'm surprised that
>>>> dtc doesn't complain about that.
>>>
>>> Agreed. I'll update the address with the reg value in the next release
>>>
>>>>
>>>>> +            compatible = "raspberrypi,rp1-clocks";
>>>>> +            reg = <0xc0 0x40018000 0x0 0x10038>;
>>>>
>>>> This is a rather oddly specific size. It leads me to wonder if this
>>>> region is inside some sort of syscon area?
>>>
>>> >From downstream source code and RP1 datasheet it seems that the last addressable
>>> register is at 0xc040028014 while the range exposed through teh devicetree ends
>>> up at 0xc040028038, so it seems more of a little safe margin. I wouldn't say it
>>> is a syscon area since those register are quite specific for video clock
>>> generation and not to be intended to be shared among different peripherals.
>>> Anyway, the next register aperture is at 0xc040030000 so I would say we can 
>>> extend the clock mapped register like the following:
>>>
>>> reg = <0xc0 0x40018000 0x0 0x18000>;
>>>
>>> if you think it is more readable.
>>
>> I don't care
> 
> Ack.
> 
>>>>> +            #clock-cells = <1>;
>>>>> +            clocks = <&clk_xosc>;
>>>>> +
>>>>> +            assigned-clocks = <&rp1_clocks RP1_PLL_SYS_CORE>,
>>>
>>>> FWIW, I don't think any of these assigned clocks are helpful for the
>>>> example. That said, why do you need to configure all of these assigned
>>>> clocks via devicetree when this node is the provider of them?
>>>
>>> Not sure to understand what you mean here, the example is there just to
>>> show how to compile the dt node, maybe you're referring to the fact that
>>> the consumer should setup the clock freq?
>>
>> I suppose, yeah. I don't think a particular configuration is relevant
>> for the example binding, but simultaneously don't get why you are
>> assigning the rate for clocks used by audio devices or ethernet in the
>> clock provider node.
>>
> 
> Honestly I don't have a strong preference here, I can manage to do some tests
> moving the clock rate settings inside the consumer nodes but I kinda like
> the curernt idea of a centralized node where clocks are setup beforehand.
> In RP1 the clock generator and peripherals such as ethernet are all on-board
> and cannot be rewired in any other way so the devices are not standalone
> consumer in their own right (such it would be an ethernet chip wired to an
> external CPU). But of course this is debatable, on the other hand the current
> approach of provider/consumer is of course very clean. I'm just wondering
> wthether you think I should take action on this or we can leave it as it is.
> Please see also below.
> 
>>> Consider that the rp1-clocks
>>> is coupled to the peripherals contained in the same RP1 chip so there is
>>> not much point in letting the peripherals set the clock to their leisure.
>>
>> How is that any different to the many other SoCs in the kernel?
> 
> In fact, it isn't. Please take a look at:
>  
> arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi
> arch/arm/boot/dts/ti/omap/omap44xx-clocks.dtsi
> arch/arm/boot/dts/ti/omap/dra7xx-clocks.dtsi
> arch/arm/boot/dts/nxp/imx/imx7d-zii-rpu2.dts
> 
> and probably many others... they use the same approach, so I assumed it is at
> least reasonable to assign the clock rate this way.

Please do not bring some ancient DTS, not really worked on, as example.
stm32 could is moderately recent but dra and omap are not.

Best regards,
Krzysztof