Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Tuesday, August 13, 2024 3:45 PM > To: Potthuri, Sai Krishna <sai.krishna.potthuri@xxxxxxx>; Linus Walleij > <linus.walleij@xxxxxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; Rob > Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > Buddhabhatti, Jay <jay.buddhabhatti@xxxxxxx>; Kundanala, Praveen Teja > <praveen.teja.kundanala@xxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-gpio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > saikrishna12468@xxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx> > Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal > platform > > On 13/08/2024 07:40, Potthuri, Sai Krishna wrote: > >> sd1_wp_0_grp, sd1_wp_1_grp, > >>> + ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp, > >> qspi0_fbclk_0_grp, qspi0_ss_0_grp, > >>> + test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp] > >>> + maxItems: 78 > >> > >> You miss minItems... I have doubts this was really tested. > > groups/pins are mentioned as required property. > > Do we still need to define minItems? > > These are two unrelated concepts. How many items can be listed at once in > each property? In this case, minItem should be 1, my understanding is since property is mentioned as required, minItem: 1 is an implicit consideration. Please correct me if my understanding is wrong. Regards Sai Krishna