RE: [PATCH v2 2/2] gpio: vf610: add get_direction() support

[Bough Chen <haibo.chen@xxxxxxx>]

> -----Original Message-----
> From: Stefan Wahren <wahrenst@xxxxxxx>
> Sent: 2024年8月2日 21:22
> To: Bough Chen <haibo.chen@xxxxxxx>; linus.walleij@xxxxxxxxxx;
> brgl@xxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/2] gpio: vf610: add get_direction() support
> 
> Hi Haibo,
> 
> Am 01.08.24 um 11:30 schrieb haibo.chen@xxxxxxx:
> > From: Haibo Chen <haibo.chen@xxxxxxx>
> >
> > For IP which do not contain PDDR, currently use the pinmux API
> > pinctrl_gpio_direction_input() to config the output/input, pinmux
> > currently do not support get_direction(). So here add the GPIO
> > get_direction() support only for the IP which has Port Data Direction
> > Register (PDDR).
> just a question about how things work:
> 
> fsl,imx7ulp-gpio and i.MX93 have PDDR, so GPIO get_direction is handled in
> gpio-vf610 driver fsl,vf610-gpio doesn't have PDDR, so all GPIO direction stuff is
> handled in pinctrl-vf610 driver
> 
> Is this correct?

Yes, correct. vf610_pmx_gpio_set_direction() did that.

Best Regards
Haibo Chen

> 
> Best regards