On 12/08/2015 04:06 PM, Geert Uytterhoeven wrote:
Add the EtherAVB pin groups to the R8A7791 PFC driver.Thanks for your patch!+static const unsigned int avb_mii_pins[] = { + RCAR_GP_PIN(5, 18), RCAR_GP_PIN(5, 19), RCAR_GP_PIN(5, 20), + RCAR_GP_PIN(5, 21), + + RCAR_GP_PIN(5, 0), RCAR_GP_PIN(5, 1), RCAR_GP_PIN(5, 2), + RCAR_GP_PIN(5, 3), + + RCAR_GP_PIN(5, 8), RCAR_GP_PIN(5, 13), RCAR_GP_PIN(5, 10), + RCAR_GP_PIN(5, 15), RCAR_GP_PIN(5, 26), RCAR_GP_PIN(5, 28), + RCAR_GP_PIN(5, 29), +}; +static const unsigned int avb_mii_mux[] = { + AVB_TXD0_MARK, AVB_TXD1_MARK, AVB_TXD2_MARK, + AVB_TXD3_MARK, + + AVB_RXD0_MARK, AVB_RXD1_MARK, AVB_RXD2_MARK, + AVB_RXD3_MARK, + + AVB_RX_ER_MARK, AVB_RX_CLK_MARK, AVB_RX_DV_MARK, + AVB_CRS_MARK, AVB_TX_EN_MARK, AVB_TX_CLK_MARK, + AVB_COL_MARK, +};The MII pin list include RX_ER, but not TX_ER...Wikipedia tells me TX_ER is optional for MII.OK. So it may make sense to have a separate pinmux group for it.
Hm... since this is MAC-to-PHY signal, I'd prefer just adding it to the MII group... but you may have a point here.
BTW, I've just noticed the R-Car Gen2 sh_eth Ethernet (which does 10/100 only) doesn't have the pin.
Th EtherMAC only support RMII which doesn't have this signal at all.
... while the GMII pin list includes both RX_ER and TX_ER. Is that correct? Should it be the other way around? Section "45A.3.13.1 MII Frame Transmission/Reception Timing" of the R-Car Gen2 datasheet shows timing diagrams for both AVB_TX_ER and AVB_RX_ER, so I'd expect both pins to be needed for MII.
Hm, interesting...
I don't have schematics for any R-Car Gen2 board that has AVB support, so I can't check myself how the MII/GMII is really wired.The standard Lager/Porter boards require some modification to use an an AVB daughter board, AFAIK.Do you have schematics for those?
Daughterboards, you mean? Yes. There are 2 of them, one with Gigabit PHY, the other with 100 Mbit one (I don't have that one and haven't tested it).
Note that this also applies to the existing AVB pinmux data in pfc-r8a7790.c.And we haven't really tested MII, only GMII.So I guess the daughterboard uses both RX_ER and TX_ER?
Yes, for the one with Gigabit PHY and no, for the one with 100 Mbit (that one doesn't even seem to have RX_ER connected to anything).
Gr{oetje,eeting}s,
Geert
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
