Re: [PATCH v5 1/4] dt-bindings: mfd: Add Analog Devices ADP5585

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On 19/07/2024 22:39, Laurent Pinchart wrote:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  gpio-reserved-ranges: true
> +
> +  "#pwm-cells":
> +    const: 3
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - "#gpio-cells"
> +  - "#pwm-cells"
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: adi,adp5585-01
> +    then:
> +      properties:
> +        gpio-reserved-ranges: false
> +    else:
> +      properties:
> +        gpio-reserved-ranges:
> +          items:
> +            - const: 5
> +            - const: 1

Why reserved ranges are fixed? If they pins are *always* not accessible,
then these are not GPIOs. This really looks incorrect.

Anyway, testing reports failures which *must* be addressed, one way or
another.


Best regards,
Krzysztof