RE: [PATCH] gpio: vf610: always set GPIO to input mode when used as interrupt source

[Bough Chen <haibo.chen@xxxxxxx>]

> -----Original Message-----
> From: Stefan Wahren <wahrenst@xxxxxxx>
> Sent: 2024年7月19日 1:09
> To: Bough Chen <haibo.chen@xxxxxxx>
> Cc: Bartosz Golaszewski <brgl@xxxxxxxx>; Linus Walleij
> <linus.walleij@xxxxxxxxxx>; open list:GPIO SUBSYSTEM
> <linux-gpio@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List
> <linux-kernel@xxxxxxxxxxxxxxx>; imx@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] gpio: vf610: always set GPIO to input mode when used as
> interrupt source
> 
> Hi,
> 
> I found this thread about the vf610 driver, because I noticed today that the
> i.MX93 is missing the GPIO get_direction callback.

I find the patch was wrong, we can't call gc.direction_input in vf610_gpio_irq_set_type(), because gc.direction_input will call pinctrl_gpio_direction_input(), this API can't be used in irq context. 

For get_direction callback, yes, I will send a patch this week.

Best Regards
Haibo Chen
> 
> Are there any plans to implement this?
> 
> Best regards